Use pointers for ng.(DesiredCapacity|MinSize|MaxSize) #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumoshu do you think you would be able to finish this up for v1alpha4 by mid-week next week? |
|
@errordeveloper Definitely 👍 |
mumoshu
force-pushed
the
proper-defaulting-nodegroup-sizing-opts
branch
from
d61779c
to
dacdd4c
Compare
mumoshu
changed the title
|
Finished manual tests on this, creating clusters with desiredCapacity/minSize/maxSize included and omitted. This should be good to go now! |
mumoshu
force-pushed
the
proper-defaulting-nodegroup-sizing-opts
branch
from
dacdd4c
to
ab8fcb0
Compare
mumoshu
force-pushed
the
proper-defaulting-nodegroup-sizing-opts
branch
from
ab8fcb0
to
4a6ebc9
Compare
errordeveloper
approved these changes
Jan 31, 2019
This was referenced Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #385 #395
Checklist